On Thu, 29 May 2003, Oliver Neukum wrote:

> 
> ax_control_msg: sleeping broken. You cannot set your task's state
> before calling usb_submit_urb because it may allocate memory, which
> may sleep and change the state to TASK_RUNNING

Any suggestions on how to best fix that?  I haven't dealt much with sleep 
states so I'm not sure what the proper way to handle it would be.  I can 
see how ax_control_msg calls ax_run_ctl_queue which submits the URB which 
is where the problem could lie.  

> 
> ax_async_cmd_callback: no need to check for NULL
> 

Ok, no prob.

> ax_rx_callback:should also include error code for adapter removal
> 
How can I check for removal.  There is the AX_DRV_STATE_EXITING state 
check, do I get anything from the USB side?

> ax_tx_callback:same as above
> dev_kfree_skb_irq( skb ); should use _any
> 
> ax8817x_bind:
> ret = usb_set_configuration( usb, 1 );
> Is this really needed?

Not sure.  I noticed that the BSD drivers did this as well.  I've wrapped 
him in an ifdef to disable it for now and will see if it makes any 
difference.  Are USB devices traditionally already set on configuration 1?

> 
>       Regards
>               Oliver
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: eBay
> Get office equipment for less on eBay!
> http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5
> _______________________________________________
> [EMAIL PROTECTED]
> To unsubscribe, use the last form field at:
> https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
> 



-------------------------------------------------------
This SF.net email is sponsored by: eBay
Get office equipment for less on eBay!
http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to