On Sun, Jun 29, 2003 at 12:16:01PM -0400, Alan Stern wrote: > On Sat, 28 Jun 2003, Matthew Dharm wrote: > > > If the files are the same now, then you should be able to apply this patch > > to 2.4 -- that's one of the reasons Alan sent you a 2.4 patch to support > > the US_*_DEVICE codes. > > > > Matt > > > > On Sat, Jun 28, 2003 at 10:39:03PM -0700, Greg KH wrote: > > > On Sat, Jun 28, 2003 at 10:36:37PM -0700, Matthew Dharm wrote: > > > > This patch re-sorts unusual_devs.h and removes some duplicate entries. > > > > > > Can you give me the same patch for 2.4 too? Right now it's easy to > > > apply the same patch to both kernels, and I'd like to keep that if > > > possible. > > > > > > thanks, > > > > > > greg k-h > > I haven't been keeping careful track, but my impression has been that some > new entries to unusual_devs.h were made for 2.4 and others for 2.5 -- > maybe the two versions of the file aren't identical. > > Perhaps they should be. One patch I sent in not too long ago removed some > flag bits that are completely unused in 2.5 and almost, but not quite, > entirely unused in 2.4. I believe the two flags were START_STOP and > IGNORE_SER. I got rid of all their occurrences in unusual_devs.h and > maybe also removed a few entries that didn't do anything once the flags > were gone.
Yes, that's the biggest difference right now. > That would account for a difference between the 2.4 and 2.5 versions. > Now 2.4 doesn't need START_STOP any more either. It looks like drivers/usb/storage/usb.c still checks for that value and does something. Is that not needed anymore? If so, can we fix this up? I'd like to be able to try to keep these files pretty close between 2.4 and 2.5, just to keep users happy mostly :) thanks, greg k-h ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel