On Mon, 30 Jun 2003, Greg KH wrote: > On Sun, Jun 29, 2003 at 12:16:01PM -0400, Alan Stern wrote: > > > > Perhaps they should be. One patch I sent in not too long ago removed some > > flag bits that are completely unused in 2.5 and almost, but not quite, > > entirely unused in 2.4. I believe the two flags were START_STOP and > > IGNORE_SER. I got rid of all their occurrences in unusual_devs.h and > > maybe also removed a few entries that didn't do anything once the flags > > were gone. > > Yes, that's the biggest difference right now. > > > That would account for a difference between the 2.4 and 2.5 versions. > > Now 2.4 doesn't need START_STOP any more either. > > It looks like drivers/usb/storage/usb.c still checks for that value and > does something. Is that not needed anymore? If so, can we fix this up?
Yes, it still does check for that value and filters those commands out. But the SCSI layer was modified not to generate those commands any more, so the checking shouldn't be necessary. It's not present in 2.5, for example. Matt, any objections to removing it from 2.4? > I'd like to be able to try to keep these files pretty close between 2.4 > and 2.5, just to keep users happy mostly :) I'll do a detailed comparison to try and get them back in sync. Alan Stern ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
