I think this is the answer then -- if you clean up this patch, I'll bless it for Greg to send on for 2.4/5/6
Matt
On Wed, Oct 22, 2003 at 03:03:40PM -0700, Stephen Hemminger wrote:
> On Wed, 22 Oct 2003 12:11:18 -0700
> Matthew Dharm <[EMAIL PROTECTED]> wrote:
>
> > Looking at this, I'm more tempted to remove the test for bType in the IRQ
> > -- this isn't the first device I've seen broken like this. It's using a
> > UFI-style CBI interrupt for a non-UFI device. This is, apparently, one of
> > many spec violations that windows silently ignores.
> >
> > Stephen, what happens if you just remove the check (search the code for the
> > line that shows "CBI IRQ data showed reserved bType")?
>
> It works fine with the check removed...
>
> diff -Nru a/drivers/usb/storage/transport.c b/drivers/usb/storage/transport.c
> --- a/drivers/usb/storage/transport.c Wed Oct 22 14:52:52 2003
> +++ b/drivers/usb/storage/transport.c Wed Oct 22 14:52:52 2003
> @@ -821,6 +821,8 @@
> }
> }
>
> +#if 0
> + /* Removed because some devices do not follow the spec. */
> /* If not UFI, we interpret the data as a result code
> * The first byte should always be a 0x0
> * The second byte & 0x0F should be 0x0 for good, otherwise error
> @@ -830,6 +832,7 @@
> us->iobuf[0]);
> return USB_STOR_TRANSPORT_ERROR;
> }
> +#endif
>
> switch (us->iobuf[1] & 0x0F) {
> case 0x00:
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
What, are you one of those Microsoft-bashing Linux freaks?
-- Customer to Greg
User Friendly, 2/10/1999
pgp00000.pgp
Description: PGP signature
