Since uhci_finish_completion is only called from IRQ routine,
the irqsave/irqrestore is redundant and unnecessary.
diff -Nru a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
--- a/drivers/usb/host/uhci-hcd.c Mon Feb 9 14:20:23 2004
+++ b/drivers/usb/host/uhci-hcd.c Mon Feb 9 14:20:23 2004
@@ -1863,9 +1863,8 @@
{
struct uhci_hcd *uhci = hcd_to_uhci(hcd);
struct list_head *tmp, *head;
- unsigned long flags;
- spin_lock_irqsave(&uhci->complete_list_lock, flags);
+ spin_lock(&uhci->complete_list_lock);
head = &uhci->complete_list;
tmp = head->next;
while (tmp != head) {
@@ -1873,15 +1872,15 @@
struct urb *urb = urbp->urb;
list_del_init(&urbp->complete_list);
- spin_unlock_irqrestore(&uhci->complete_list_lock, flags);
+ spin_unlock(&uhci->complete_list_lock);
uhci_finish_urb(hcd, urb, regs);
- spin_lock_irqsave(&uhci->complete_list_lock, flags);
+ spin_lock(&uhci->complete_list_lock);
head = &uhci->complete_list;
tmp = head->next;
}
- spin_unlock_irqrestore(&uhci->complete_list_lock, flags);
+ spin_unlock(&uhci->complete_list_lock);
}
static void uhci_remove_pending_qhs(struct uhci_hcd *uhci)
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
