uhci_finish_urb is always called from irq so no need for irqsave/irqrestore.
diff -Nru a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c --- a/drivers/usb/host/uhci-hcd.c Mon Feb 9 12:54:47 2004 +++ b/drivers/usb/host/uhci-hcd.c Mon Feb 9 12:54:47 2004 @@ -1845,15 +1845,14 @@ struct urb_priv *urbp = (struct urb_priv *)urb->hcpriv; struct uhci_hcd *uhci = hcd_to_uhci(hcd); int status; - unsigned long flags; - spin_lock_irqsave(&urb->lock, flags); + spin_lock(&urb->lock); status = urbp->status; uhci_destroy_urb_priv(uhci, urb); if (urb->status != -ENOENT && urb->status != -ECONNRESET) urb->status = status; - spin_unlock_irqrestore(&urb->lock, flags); + spin_unlock(&urb->lock); usb_hcd_giveback_urb(hcd, urb, regs); } ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel