On Mon, 9 Feb 2004 14:58:54 -0800
Johannes Erdfelt <[EMAIL PROTECTED]> wrote:
> On Mon, Feb 09, 2004, Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> > @@ -669,7 +669,6 @@
> >
> > INIT_LIST_HEAD(&urbp->td_list);
> > INIT_LIST_HEAD(&urbp->queue_list);
> > - INIT_LIST_HEAD(&urbp->complete_list);
> > INIT_LIST_HEAD(&urbp->urb_list);
> >
> > list_add_tail(&urbp->urb_list, &uhci->urb_list);
> > @@ -720,9 +719,6 @@
> > if (!list_empty(&urbp->urb_list))
> > warn("uhci_destroy_urb_priv: urb %p still on uhci->urb_list or
> > uhci->remove_list", urb);
> >
> > - if (!list_empty(&urbp->complete_list))
> > - warn("uhci_destroy_urb_priv: urb %p still on uhci->complete_list",
> > urb);
> > -
> > spin_lock_irqsave(&uhci->td_remove_list_lock, flags);
> >
> > /* Check to see if the remove list is empty. Set the IOC bit */
>
> I'd change the message above it to say something "still on list" since
> it can be urb_list, remove_list or complete_list with this patch.
>
> Or just delete the message entirely, it's just debugging and no one has
> ever hit it :)
One of the next patches (10 seemed enough for today). Gets rid of the
message and uses list_del rather than list_del_init, so if it ever hit
then the LIST_POISON macros would catch it.
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
