Hi Deepak,
* Deepak Saxena <[EMAIL PROTECTED]> [040209 12:18]:
>
> In reply to this message I will post a set of patches that cleanup
> the USB driver layer to use the generic DMA-mapping API and dma_pools
> vs pci_pools.
Just tried your patch out on OMAP against linux-2.6.3-rc2. The OHCI
controller works just fine after I applied a little patch to use the
dma_alloc_coherent below. Can you please apply it on top of your
patches? As far as I'm concerned, looks good!
Regards,
Tony
diff -Nru a/drivers/usb/host/ohci-mem.c b/drivers/usb/host/ohci-mem.c
--- a/drivers/usb/host/ohci-mem.c Tue Feb 10 14:22:10 2004
+++ b/drivers/usb/host/ohci-mem.c Tue Feb 10 14:22:10 2004
@@ -13,7 +13,7 @@
* There's basically three types of memory:
* - data used only by the HCD ... kmalloc is fine
* - async and periodic schedules, shared by HC and HCD ... these
- * need to use dma_pool or dma_alloc_consistent
+ * need to use dma_pool or dma_alloc_coherent
* - driver buffers, read/written by HC ... the hcd glue or the
* device driver provides us with dma addresses
*
diff -Nru a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c
--- a/drivers/usb/host/ohci-omap.c Tue Feb 10 14:22:10 2004
+++ b/drivers/usb/host/ohci-omap.c Tue Feb 10 14:22:10 2004
@@ -495,8 +495,8 @@
int ret;
if (hcd->dev) {
- ohci->hcca = dma_alloc_consistent (hcd->dev,
- sizeof *ohci->hcca, &ohci->hcca_dma);
+ ohci->hcca = dma_alloc_coherent (hcd->dev,
+ sizeof *ohci->hcca, &ohci->hcca_dma, 0);
if (!ohci->hcca)
return -ENOMEM;
}
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
