On Feb 10 2004, at 17:45, David Brownell was caught saying: > Tony Lindgren wrote: > >* Deepak Saxena <[EMAIL PROTECTED]> [040210 15:04]: > > > >>I don't understand why we need this if statement. I see the same > >>in ohci-sa1111.c. I haven't completely groked the whole USB layer, > >>but how whould hcd->dev ever be NULL? I thought each hcd/usb_bus > >>must have a device associated with it. > > > > > >Don't ask me, I just copied it from sa1111 :) Works fine without it though. > >But I guess I just don't know how to reproduce the hcd->dev == NULL... > <snip> > But Chris Hoover's sa1111 patches went the "fake pci device" route, > so it hasn't ever really been null. And today, people should be > going the "real struct device" route. > > So at this point it seems like cargo-cult coding to me ... worth > getting rid of. ;)
Ok. Adding it to next patchset. ~Deepak -- Deepak Saxena - dsaxena at plexity dot net - http://www.plexity.net/ ------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
