On Feb 10 2004, at 14:33, Tony Lindgren was caught saying:
> Hi Deepak,
>
> * Deepak Saxena <[EMAIL PROTECTED]> [040209 12:18]:
> >
> > In reply to this message I will post a set of patches that cleanup
> > the USB driver layer to use the generic DMA-mapping API and dma_pools
> > vs pci_pools.
>
> Just tried your patch out on OMAP against linux-2.6.3-rc2. The OHCI
> controller works just fine after I applied a little patch to use the
> dma_alloc_coherent below. Can you please apply it on top of your
> patches? As far as I'm concerned, looks good!
Will add to my next patchset, but I have a question below:
> diff -Nru a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c
> --- a/drivers/usb/host/ohci-omap.c Tue Feb 10 14:22:10 2004
> +++ b/drivers/usb/host/ohci-omap.c Tue Feb 10 14:22:10 2004
> @@ -495,8 +495,8 @@
> int ret;
>
> if (hcd->dev) {
I don't understand why we need this if statement. I see the same
in ohci-sa1111.c. I haven't completely groked the whole USB layer,
but how whould hcd->dev ever be NULL? I thought each hcd/usb_bus
must have a device associated with it.
~Deepak
--
Deepak Saxena - dsaxena at plexity dot net - http://www.plexity.net/
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
