David:

Overall I think this looks pretty good.  Here are a few suggestions for 
some small changes.

        It would be nice if the library routines were cognizant of the
        bus speed required for the endpoint.  You could add an enum 
        usb_device_speed argument to usb_ep_autoconfig().  If nothing
        else, you could use it to set the bulk maxpacket value correctly.

        As a matter of form, I dislike the way the maxpacket value is
        updated for bulk descriptors while there's still a possibility
        for the match to fail.

        You mention adding support for separate IN and OUT ep number
        counters.  Might as well do it now.

        Could you export some form of "controller-type" number (1 for
        net2280, 3 for pxa, etc.) to simplify the bcdDevice assignment
        for gadget drivers that use the same scheme as gadget-zero?

Alan Stern



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to