David:
Overall I think this looks pretty good. Here are a few suggestions for some small changes.
It would be nice if the library routines were cognizant of the
bus speed required for the endpoint. You could add an enum usb_device_speed argument to usb_ep_autoconfig(). If nothing
else, you could use it to set the bulk maxpacket value correctly.
Not needed ... high speed bulk maxpacket is fixed size.
That could affect high speed periodic transfers, but since we don't have any drivers using those yet I'm sort of reluctant to try supporting such things. So I'll hold off on that for now.
As a matter of form, I dislike the way the maxpacket value is
updated for bulk descriptors while there's still a possibility
for the match to fail.
Whoops -- that wasn't a good cleanup! Restored to its previous state, modulo ...
You mention adding support for separate IN and OUT ep number
counters. Might as well do it now.
... this point. Although I'll #ifdef out that mode by default. Most hardware doesn't have more than 15 endpoints, and it's also easier to talk about things when "ep1" is unambiguous.
Could you export some form of "controller-type" number (1 for
net2280, 3 for pxa, etc.) to simplify the bcdDevice assignment
for gadget drivers that use the same scheme as gadget-zero?
I'd rather hold that off. Managing a number namespace for all developers is extra administrative overhead. I don't want to be maintaining such a list, or expect LANA to do so. (ARM has a webpage and web form to assign MACH_* names and constants, and it need manual care and feeding...) Plus it's not necessary ... developers already keep driver names unique enough, to avoid filename collisions.
It's an issue worth watching though.
- Dave
Alan Stern
------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
