On Wed, Apr 28, 2004 at 07:40:33PM +0200, Marcel Holtmann wrote:
> Hi Alan,
> 
> > Your recent change to struct urb broke this function in the bluetooth 
> > driver.  You know, I think usb_wait_for_urb() would make an excellent 
> > addition to usbcore.  At some future time we could consider replacing 
> > synchronous unlink_urb with asynchronous unlink plus wait_for_urb.
> 
> is the change from count to kref already in the current Linus kernel?

No, it's in the -mm tree only.  It's pending for 2.6.7, so you don't
have to worry about it just yet.

> I think we should add the usb_wait_for_urb() for now, because I have to
> use it in two driver now (hci_usb and bfusb) and so USB interna can be
> changed without fixing the drivers.

No, see my previous objections to this function (wrong, and broken.)

Again, any reason why you can not just create a urb on the fly instead
of insisting that it be embedded in your own structure?

thanks,

greg k-h


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE. 
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to