While looking through the irda-usb driver, I found that it does several
questionable things.

        irda_urb_net_timeout() looks at urb->status while the URB is
        still in progress.

        Even worse, it changes urb->status!

        The driver uses the urb->timeout field.  This field is supported
        only by the UHCI driver, and I would like to remove that support.

Right now there are only about 3 drivers that use urb->timeout.  My
feeling is that we should either remove timeout support entirely or else
move it to usbcore, where it will work with every HCD.  This wouldn't be
such a bad thing to do; in fact we could simply take the code already used
by usb_bulk/control_message() and put it in a more central location.  (If 
it were available in this way, usb-storage could be simplified.)

Comments?

Alan Stern



-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to