On Sun, 16 May 2004, Greg KH wrote: > On Sun, May 16, 2004 at 12:01:03PM -0400, Alan Stern wrote: > > While looking through the irda-usb driver, I found that it does several > > questionable things. > > > > irda_urb_net_timeout() looks at urb->status while the URB is > > still in progress. > > > > Even worse, it changes urb->status! > > Ick ick ick. That's wrong and needs to be fixed.
I'm not touching that; I don't know the first thing about the driver. There are no dates later than 2001 in the source, which makes me wonder if driver is actively maintained? > > The driver uses the urb->timeout field. This field is supported > > only by the UHCI driver, and I would like to remove that support. > > You mean the ohci and ehci drivers do not support that? Since when? We > need to update the documentation if that is true... As far as I know, since always. (The hc_simple driver seems to support it though; I tend to forget about those oddball drivers...) There _is_ a comment in irda-usb.c mentioning that the timeouts work only with UHCI -- it looks like it's been in there for quite some time. > > Right now there are only about 3 drivers that use urb->timeout. My > > feeling is that we should either remove timeout support entirely or else > > move it to usbcore, where it will work with every HCD. This wouldn't be > > such a bad thing to do; in fact we could simply take the code already used > > by usb_bulk/control_message() and put it in a more central location. (If > > it were available in this way, usb-storage could be simplified.) > > Move it to the core so that it actually works would be good. That's a project for the future. Unless someone else would like to do it first, I'll look at that when I remove timeouts from the UHCI driver. Alan Stern ------------------------------------------------------- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
