On Sat, May 29, 2004 at 09:02:44PM -0700, Matthew Dharm wrote: > On Sat, May 29, 2004 at 07:47:55AM -0700, Greg KH wrote: > > On Sat, May 29, 2004 at 04:13:24PM +0200, Vojtech Pavlik wrote: > > > On Sat, May 29, 2004 at 03:23:09PM +0200, Oliver Neukum wrote: > > > > > > > > Here I have this patch ported from a 2.4 verison of a patch by guy at > > > > > Dell ([EMAIL PROTECTED]), that uses the serialize semaphore in devio.c > > > > > and in usb-storage. > > > > > > > > > > This is needed on storage devices, where even sending a harmless > > > > > GET_DESCRIPTOR command at the wrong time will lead to a STALL condition, > > > > > > > It seems to me that you should hold the semaphore until after the reset > > > > of the error case. You are dropping it too early. > > > > > > Ok, how about this one? > > > > It looks ok to me, Matt, what do you think? > > I want to hear more from Oliver and Alan about holding the semaphore during > reset. > > IIRC, something like this is already being talked about for 2.6, isn't it?
I don't know - if yes, then great and my patch may not be needed. -- Vojtech Pavlik SuSE Labs, SuSE CR ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel