-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
> > + } else do {
> > +
> > + // create a new image and check for success
> > + result = idmouse_create_image (dev);
> > + if (result)
> > + break;
> > +
> > + // increment our usage count for the driver
> > + ++dev->open;
> > +
> > + // save our object in the file's private structure
> > + file->private_data = dev;
> > +
> > + } while (0);
>
> What do you intend with that loop?
> If you want goto, use it, not break.
Okay, maybe it's a kludge. But goto is, too. In any case, the
most clear solution would be
+ if (result) {
+
+ // unlock this device
+ up(&dev->sem);
+
+ // unlock the disconnect semaphore
+ up(&disconnect_sem);
+ return result;
+ }
Agreed?
> > + --dev->open;
> > +
> > + if (!dev->present && !dev->open) {
> How could dev->open not be 0?
You have a point there, I overlooked that. usb-skeleton allows
multiple open()s.
However, none of these does change any functionality, so before
resubmitting the patch, I'd like to hear Greg's opinion.
Yours,
Florian
- --
Homo homini lupus.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFBDjLa7CzyshGvatgRAhJ3AKCaqrJhla/5AQ/06Eo4N8alQSTF6ACgoc9c
X6p3TYdX8CMpCNu5qz3jZOY=
=qvoV
-----END PGP SIGNATURE-----
-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
