On Tue, Aug 03, 2004 at 12:19:25PM +0200, Florian Echtler wrote:
> Next iteration, now hopefully with all bugs and ugliness issues fixed.

Oh, so close, only a few minor issues:

> diff --unified --recursive --new-file linux-2.6.7/drivers/usb/Makefile 
> linux/drivers/usb/Makefile
> --- linux-2.6.7/drivers/usb/Makefile  2004-06-16 07:20:04.000000000 +0200
> +++ linux/drivers/usb/Makefile        2004-07-30 14:12:48.000000000 +0200
> @@ -67,3 +67,4 @@
>  obj-$(CONFIG_USB_TIGL)               += misc/
>  obj-$(CONFIG_USB_USS720)     += misc/
>  obj-$(CONFIG_USB_PHIDGETSERVO)       += misc/
> +obj-$(CONFIG_USB_IDMOUSE)    += misc/

Please place this in the proper, sorted order.  Same with the Kconfig
and other Makefile.

> diff --unified --recursive --new-file linux-2.6.7/drivers/usb/misc/idmouse.c 
> linux/drivers/usb/misc/idmouse.c
> --- linux-2.6.7/drivers/usb/misc/idmouse.c    1970-01-01 01:00:00.000000000 +0100
> +++ linux/drivers/usb/misc/idmouse.c  2004-07-30 14:26:15.000000000 +0200
> @@ -0,0 +1,455 @@
> +/* Siemens ID Mouse driver v0.4
> +
> +   This file is licensed under the GNU Public License.

Which version of the license?

No copyright notice?

Oh, and how about a link to your userspace tools that you need to have
in order for this to work?

thanks,

greg k-h


-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to