-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
> > +static int idmouse_release(struct inode *inode, struct file *file)
> You should be taking disconnect_sem here instead. Think about it:
> you are competing with an open. What happens there?
Hmm, you're right, but dev->sem is IMHO still needed to protect
access to dev. Best solution would be to protect the entire release
function by disconnect_sem.
> > + } else do {
> You will burn in hell for this.
All right, all right, I'll change it to a goto before I get drawn
and quartered..
> And since we are at it, is there a particular reason for this device driver
> to be in the kernel?
In fact, there is: we first tried a userspace implementation with libusb,
but the sensor is awfully picky about packet timing. In userspace, you
get garbled/distorted pictures most of the time, while the kernel driver
doesn't have these problems.
Yours, Florian
- --
Homo homini lupus.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFBDma57CzyshGvatgRAswbAJoDTtxyUfRnWa/Cy1kBTWpPy4PFUgCfbem6
0xy1QX9MEkUxnNH7C8ad6MI=
=YV5a
-----END PGP SIGNATURE-----
-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
