Am Montag, 27. November 2006 17:25 schrieb David Brownell:
> On Monday 27 November 2006 12:35 am, Oliver Neukum wrote:
> > Am Montag, 27. November 2006 04:22 schrieb David Brownell:
> > > On Sunday 26 November 2006 6:46 pm, Alan Stern wrote:
> > > > On Sun, 26 Nov 2006, David Brownell wrote:
> > > >
> > > > > On Thursday 23 November 2006 6:19 am, Oliver Neukum wrote:
> > > > > > Hi,
> > > > > >
> > > > > > gl620a uses a buffer within a struct. This can corrupt memory on
> > > > > > machines
> > > > > > that are not cache coherent.
> > > > >
> > > > > How could it possibly corrupt memory?
> > > >
> > > > It would be more accurate to say that it could corrupt the contents of
> > > > the
> > > > buffer during an input operation. I don't think it matters as far as
> > > > output is concerned...
> > >
> > > The question still remains: how could this corruption happen?
> >
> > On third look, why does this driver submit an URB for data
> > it never reads? There's something fishy. It even more or less ignores
> > the status.
>
> Now that you mention it ... last I knew, that whole IRQ mechanism
> is completely disabled. Not only was it relevant only for the gl620,
> not the gl620a, it wasn't implemented right even for that chip variant.
>
> In fact the comment preceding what you patched more or less says so...
Yes, I considered it an experimental feature.
If it is abandoned code I suggest that it is removed, or if not, that the
patch be applied, because it will backfire later on.
Regards
Oliver
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
