Hi Pete, > > The usb_buffer_alloc() and usb_buffer_free() usage was taken from the > > skeleton example driver. No idea if that is a good idea or not. I was > > under the impression that using the provided helper function that take > > care of DMA is a good thing. > > Just as I suspected. > > You know, if you used kmalloc instead, usb_setup_bulk_urb would be > useful for my update of usblp.c.
that would be easy to change. My patch was actually not complete at all since the helpers for interrupt and isosynchronous URBs were missing. It was a request for comments for the USB core developers to see if this approach would be accepted. I actually don't know if usb_buffer_alloc() buys us anything. I leave this up to the USB experts. Regards Marcel ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
