On Sun, May 30, 2004 at 10:43:14AM +0200, Christoph Hellwig wrote: > Avoid Scsi_Foo typefs and scsi_to_pci_dma_dir. Use proper <scsi/*.h> > headers. This also includes some additional reshuffling due to avoiding > useless headers in the usb-storage local headers. If you don't like > that part just drop it, but it should reduce compile-time a little ;-) >
Christoph --
I fixed up your patch to adjust for some recent patches applied ahead of
yours. However, when I try to build I get the following error. Any chance
for a revised patch?
Matt
CC [M] drivers/usb/storage/scsiglue.o
In file included from include/linux/dma-mapping.h:16,
from include/scsi/scsi_cmnd.h:4,
from drivers/usb/storage/scsiglue.c:52:
include/asm/dma-mapping.h:12: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h:12: warning: its scope is only this definition or
declaration, which is probably not what you want
include/asm/dma-mapping.h:15: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h:19: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h:28: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h:35: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h: In function `dma_map_sg':
include/asm/dma-mapping.h:44: `mem_map' undeclared (first use in this function)
include/asm/dma-mapping.h:44: (Each undeclared identifier is reported only once
include/asm/dma-mapping.h:44: for each function it appears in.)
include/asm/dma-mapping.h: At top level:
include/asm/dma-mapping.h:53: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h: In function `dma_map_page':
include/asm/dma-mapping.h:56: `mem_map' undeclared (first use in this function)
include/asm/dma-mapping.h: At top level:
include/asm/dma-mapping.h:61: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h:69: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h:76: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h:82: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h:90: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h:97: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h:104: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h:110: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h:122: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h:136: warning: `struct device' declared inside parameter list
include/asm/dma-mapping.h: In function `dma_set_mask':
include/asm/dma-mapping.h:138: dereferencing pointer to incomplete type
include/asm/dma-mapping.h:138: warning: passing arg 1 of `dma_supported' from
incompatible pointer type
include/asm/dma-mapping.h:141: dereferencing pointer to incomplete type
In file included from include/linux/pagemap.h:7,
from include/linux/blkdev.h:10,
from drivers/usb/storage/usb.h:48,
from drivers/usb/storage/scsiglue.c:59:
include/linux/mm.h: At top level:
include/linux/mm.h:400: `mem_map' used prior to declaration
make[3]: *** [drivers/usb/storage/scsiglue.o] Error 1
make[2]: *** [drivers/usb/storage] Error 2
make[1]: *** [drivers/usb] Error 2
make: *** [drivers] Error 2
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
You are needink to look more evil. You likink very strong coffee?
-- Pitr to Dust Puppy
User Friendly, 10/16/1998
pgppfIErRrAO8.pgp
Description: PGP signature
