On Mon, Jun 14, 2004 at 09:59:36AM +0200, Christoph Hellwig wrote: > On Sun, Jun 13, 2004 at 08:29:39PM -0700, Matthew Dharm wrote: > > I fixed up your patch to adjust for some recent patches applied ahead of > > yours. However, when I try to build I get the following error. Any chance > > for a revised patch? > > > > Matt > > > > > > CC [M] drivers/usb/storage/scsiglue.o > > In file included from include/linux/dma-mapping.h:16, > > from include/scsi/scsi_cmnd.h:4, > > from drivers/usb/storage/scsiglue.c:52: > > include/asm/dma-mapping.h:12: warning: `struct device' declared inside parameter > > list > > include/asm/dma-mapping.h:12: warning: its scope is only this definition or > > declaration, which is probably not what you want > > you asm/dma-mapping.h misses a struct device forward declaration > somewhere. What architecture is this on? Works for me on ppc.
This is x86.
> > include/asm/dma-mapping.h: In function `dma_map_sg':
> > include/asm/dma-mapping.h:44: `mem_map' undeclared (first use in this function)
>
> And it's missing a linux/mm.h include.
>
> Can you try fixing up asm/dma-mapping.h? As a workaround you could also
> include <linux/mm.h> and <linux/device.h> before including
> <scsi/scsi_cmnd.h> everywhere but I'd rather get the broken header
> fixed.
I'll take a look, but this is a bad week for me (when isn't?).
Matt
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
Now payink attention, please. This is mouse. Click-click. Easy to
use, da? Now you try...
-- Pitr to Miranda
User Friendly, 10/11/1998
pgpSq08UT2TwD.pgp
Description: PGP signature
