On Sun, May 30, 2004 at 10:43:14AM +0200, Christoph Hellwig wrote:
> Avoid Scsi_Foo typefs and scsi_to_pci_dma_dir. Use proper <scsi/*.h>
> headers. This also includes some additional reshuffling due to avoiding
> useless headers in the usb-storage local headers. If you don't like
> that part just drop it, but it should reduce compile-time a little ;-)
>
> ===== drivers/usb/storage/usb.c 1.86 vs edited =====
> --- 1.86/drivers/usb/storage/usb.c 2004-04-25 04:25:23 +02:00
> +++ edited/drivers/usb/storage/usb.c 2004-05-22 16:13:31 +02:00
> @@ -322,7 +327,7 @@
> /* reject the command if the direction indicator
> * is UNKNOWN
> */
> - else if (us->srb->sc_data_direction == SCSI_DATA_UNKNOWN) {
> + else if (us->srb->sc_data_direction == DMA_NONE) {
> US_DEBUGP("UNKNOWN data direction\n");
> us->srb->result = DID_ERROR << 16;
> }
Is this valid? Of the cuff, this seems to be a significant semantic change
from 'unknown' to 'none'.
Matt
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
My mother not mind to die for stoppink Windows NT! She is rememberink
Stalin!
-- Pitr
User Friendly, 9/6/1998
pgppywhjQ6PXS.pgp
Description: PGP signature
