What's wrong with this? We need to hold the spinlock to prevent the
disconnect function from proceeding while we are using the device.
The spinlock we are holding is a private spinlock. I don't see what you
think is wrong.
Matt Dharm
On Sat, 1 Apr 2000, Pavel Machek wrote:
> Hi!
>
> USB storage race is still there: in Bulk_transport, you are doing
>
> @@ -991,6 +976,9 @@
> US_DEBUGP("Bulk command S 0x%x T 0x%x L %d F %d CL %d\n",
> bcb.Signature, bcb.Tag, bcb.DataTransferLength,
> bcb.Flags, bcb.Length);
> +/* BUG BUG BUG!
> + We are calling schedule, but we are holding spinlock_irqsave!
> +*/
> result = usb_bulk_msg(us->pusb_dev, pipe, &bcb,
> US_BULK_CB_WRAP_LEN, &partial, HZ*5);
> US_DEBUGP("Bulk command transfer result=%d\n", result);
>
> which just can't be right.
>
> Pavel
>
>
--
Matthew Dharm Home: [EMAIL PROTECTED]
Engineer, Qualcomm, Inc. Work: [EMAIL PROTECTED]
But where are the THEMES?! How do you expect me to use an OS without
themes?!
-- Stef
User Friendly, 10/9/1998
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
