Hi,
Thanks for testing and feedbacks.
> 1) The build system seems broken to me:
>
> * It doesn't set proper permissions (e.g root for ift-load)
Is it a bug of permissions or ownership ?
> And that would still generate "//lib/firmware..." path. Because of the
> -prefix=/ I pressume.
/lib/firmware have nothing to do with ${prefix} and friends, it is
hardcoded both in ift-extract and isight.rules. ift-extract has an
option if you want to output in a different directory (e.g. '.'), see
info ift-extract. Only ${sysconfdir} should be overriden for proper
installation of the udev rules.
> 2) Probably the USB_BUS and USB_DEV env variables are not set
> as you seem to expect them to be in ift-load. May be you should either
> pass those explicitly in the udev rule or just make ift-load find the
> device itself basid on the device and vendor id?
Do you have the firmware in /lib/firmware/isight.fw ? I dropped device
probe because it's udev job. Please confirm the bug. Write a udev rules
running a script which dump `export` to a log file to see what info udev
exports in env.
> 4) * Meant to use syslog/vsyslog functions (instead of g_error) to send
> the log messages to the syslog.
If you read carefully the beginning of load.c, it overload
g_{message,warning,error} ;). I renamed them to
ift_{message,warning,error} to avoid confusion. ift_error uses exit(-1)
instead of abort() as overloaded g_error() did.
> * openlog("ift-extract", 0, LOG_SYSLOG); - That should probably be
> something like:
>
> openlog("ift-load", LOG_PERROR, LOG_USER);
Fixed, thanks.
I produce a 0.5.1 bugfixe release with your feedbacks. Don't hesitate to
provide deeper info. I don't mind releasing several releases per
weeks ;)
Regards,
Étienne.
_______________________________________________
Linux-uvc-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/linux-uvc-devel
