Étienne Bersac wrote:
> Hi,
>
> Thanks for testing and feedbacks.
>
>> 1) The build system seems broken to me:
>>
>> * It doesn't set proper permissions (e.g root for ift-load)
>
> Is it a bug of permissions or ownership ?
Ownership.
>
>> And that would still generate "//lib/firmware..." path. Because of the
>> -prefix=/ I pressume.
>
> /lib/firmware have nothing to do with ${prefix} and friends, it is
> hardcoded both in ift-extract and isight.rules. ift-extract has an
> option if you want to output in a different directory (e.g. '.'), see
> info ift-extract. Only ${sysconfdir} should be overriden for proper
> installation of the udev rules.
>
Please apologies me for the confusion. I meant the following snippet
from isight.rules.in:
RUN+="@prefix@/lib/udev/ift-load -f /lib/firmware/isight.fw"
becomes (with --prefix=/) :
RUN+="//lib/udev/ift-load -f /lib/firmware/isight.fw"
>> 2) Probably the USB_BUS and USB_DEV env variables are not set
>> as you seem to expect them to be in ift-load. May be you should either
>> pass those explicitly in the udev rule or just make ift-load find the
>> device itself basid on the device and vendor id?
>
> Do you have the firmware in /lib/firmware/isight.fw ? I dropped device
> probe because it's udev job. Please confirm the bug. Write a udev rules
> running a script which dump `export` to a log file to see what info udev
> exports in env.
>
Yes I have the firmware in place.
Firstly in order to make the udev rule to get executed I had to change
SUBSYSTEM=="usb_device" to "usb". "usb_device" seems deprecated. As you
can see there is no USB_DEV nor USB_BUS here:
declare -x ACTION="add"
declare -x DEVICE="/proc/bus/usb/005/003"
declare -x DEVPATH="/devices/pci0000:00/0000:00:1d.7/usb5/5-4/5-4:1.0"
declare -x DEVTYPE="usb_interface"
declare -x INTERFACE="255/255/255"
declare -x MODALIAS="usb:v05ACp8300d010DdcFFdscFFdpFFicFFiscFFipFF"
declare -x OLDPWD
declare -x PRODUCT="5ac/8300/10d"
declare -x PWD="/"
declare -x SEQNUM="1444"
declare -x SHLVL="1"
declare -x SUBSYSTEM="usb"
declare -x TYPE="255/255/255"
declare -x UDEVD_EVENT="1"
declare -x UDEV_LOG="3"
>> 4) * Meant to use syslog/vsyslog functions (instead of g_error) to send
>> the log messages to the syslog.
>
> If you read carefully the beginning of load.c, it overload
> g_{message,warning,error} ;). I renamed them to
> ift_{message,warning,error} to avoid confusion. ift_error uses exit(-1)
> instead of abort() as overloaded g_error() did.
>
>> * openlog("ift-extract", 0, LOG_SYSLOG); - That should probably be
>> something like:
>>
>> openlog("ift-load", LOG_PERROR, LOG_USER);
>
> Fixed, thanks.
>
>
> I produce a 0.5.1 bugfixe release with your feedbacks. Don't hesitate to
> provide deeper info. I don't mind releasing several releases per
> weeks ;)
>
>
> Regards,
> Étienne.
>
_______________________________________________
Linux-uvc-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/linux-uvc-devel
