Hi Kalle, On Fri, 2019-09-13 at 13:24 +0300, Kalle Valo wrote: > James Prestwood <prest...@gmail.com> writes: > > > I know 3ms doesn't seems like a lot but everything counts and from > > my > > testing this is even a further 20% improvement to doing so with > > RTNL. > > Plus the added simplicity to the userspace code/API. We have taken > > a > > lot of time to optimize IWD's connection times, and everything > > counts. > > The connection times are fast already, but when there is room for > > improvement we will push for it, especially in situations like this > > when the change is quite minimal and does not introduce much > > complexity. > > So what kind of _total_ connection times you get now? >
This really depends. Most of the optimizations I was referencing are due to scanning optimizations and moving DHCP into IWD itself, but both of these are kinda irrelevant in this case so I wont consider them. With this change, looking at the time from CMD_CONNECT until EAPoL/key setting has finished I calculated 111.4ms on average. This is about a 3.5x speed up from the current method (Power down + RTNL) which I calculated to be 391.8ms average. Note, this is rough (averaged only 5 runs just now). So the savings are still significant even if you look at the full connection times. The difference between doing the MAC change with RTNL vs CMD_CONNECT are not as drastic, but from my perspective I would say what's the harm? Your gaining further speed ups with really no added complexity. Thanks, James
