On Wed, Aug 01, 2007 at 06:13:04PM +0400, Valentine Barshak wrote:
> David Gibson wrote:
> > On Mon, Jul 30, 2007 at 07:06:48PM +0400, Valentine Barshak wrote:
[snip]
> >> + SDR0: sdr {
> >
> > What is the SDR?
>
> SDR are System Device Control Registers (chip ID, pin function and stuff).
> They are accessed by using the configuration address and data (CFGADDR
> and CFGDATA) registers.
Ok.
> >> + compatible = "ibm,sdr-440ep";
> >> + dcr-reg = <00e 002>;
> >> + };
> >> +
> >> + CPR0: cpr {
> >
> > And the CPR?
>
> CPR are Clock/Power-On Reset configuration registers.
> They are also accessed by using the configuration address and data
> (CFGADDR and CFGDATA) registers.
Ok, so the rough equivalent of the 440GP's CPC registers (but with an
entirely different register layout).
[snip]
> >> + EMAC0: [EMAIL PROTECTED] {
> >> + linux,network-index = <0>;
> >> + device_type = "network";
> >> + compatible = "ibm,emac-440spe", "ibm,emac4",
> >> "ibm,emac-axon";
> >
> > "ibm,emac-axon" is definitely wrong, since this isn't an Axon chip.
>
> The chip uses EMACX_STACR_STAC_READ and EMACX_STACR_STAC_WRITE bits with
> mdio_read/mdio_write commands. These are only enabled if the chip is
> axon-compatible.
> ---
> if (device_is_compatible(np, "ibm,emac-axon"))
> dev->features |= EMAC_FTR_HAS_AXON_STACR
> ---
Then the driver needs fixing; I'll talk to Ben and look into it.
We'll need something in the device tree to indicate this, but it
shouldn't be "emac-axon" in compatible.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
