On Mon, 05 Jan 2026 14:33:41 +0100 Krzysztof Kozlowski <[email protected]> wrote:
> Use scoped for-each loop when iterating over device nodes to make code a > bit simpler. > > Signed-off-by: Krzysztof Kozlowski <[email protected]> > > --- A suggestion inline, but assuming you don't go with that, this is fine. Reviewed-by: Jonathan Cameron <[email protected]> > > Depends on the first patch. > --- > arch/arm/mach-exynos/exynos.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c > index 2e8099479ffa..18695076c34e 100644 > --- a/arch/arm/mach-exynos/exynos.c > +++ b/arch/arm/mach-exynos/exynos.c > @@ -47,9 +47,7 @@ unsigned int exynos_rev(void) > > void __init exynos_sysram_init(void) > { > - struct device_node *node; > - > - for_each_compatible_node(node, NULL, "samsung,exynos4210-sysram") { > + for_each_compatible_node_scoped(node, NULL, > "samsung,exynos4210-sysram") { > struct resource res; > if (!of_device_is_available(node)) > continue; No idea how common this pattern is, but maybe worth for_each_compatible_available_node_scoped() ? Bit of a pain as you'd need a of_find_compatible_available_node() helper. So I'll let you assess if there are enough instances of this to make it worthwhile. > @@ -57,15 +55,13 @@ void __init exynos_sysram_init(void) > of_address_to_resource(node, 0, &res); > sysram_base_addr = ioremap(res.start, resource_size(&res)); > sysram_base_phys = res.start; > - of_node_put(node); > break; > } > > - for_each_compatible_node(node, NULL, "samsung,exynos4210-sysram-ns") { > + for_each_compatible_node_scoped(node, NULL, > "samsung,exynos4210-sysram-ns") { > if (!of_device_is_available(node)) > continue; > sysram_ns_base_addr = of_iomap(node, 0); > - of_node_put(node); > break; > } > } >
