On Mon, 05 Jan 2026 14:33:45 +0100 Krzysztof Kozlowski <[email protected]> wrote:
> Use scoped for-each loop when iterating over device nodes to make code a > bit simpler. > > Signed-off-by: Krzysztof Kozlowski <[email protected]> Reviewed-by: Jonathan Cameron <[email protected]> This is one that had me thinking for a (short) while about what pattern required this double match was there for. A comment would have been useful! Ah well, nothing to do with your patch which is good. Jonathan > > --- > > Depends on first patch. > --- > drivers/clk/imx/clk-imx27.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx27.c b/drivers/clk/imx/clk-imx27.c > index 99618ded0939..f2f0d3fe5c52 100644 > --- a/drivers/clk/imx/clk-imx27.c > +++ b/drivers/clk/imx/clk-imx27.c > @@ -171,17 +171,14 @@ static void __init _mx27_clocks_init(unsigned long fref) > > static void __init mx27_clocks_init_dt(struct device_node *np) > { > - struct device_node *refnp; > u32 fref = 26000000; /* default */ > > - for_each_compatible_node(refnp, NULL, "fixed-clock") { > + for_each_compatible_node_scoped(refnp, NULL, "fixed-clock") { > if (!of_device_is_compatible(refnp, "fsl,imx-osc26m")) > continue; > > - if (!of_property_read_u32(refnp, "clock-frequency", &fref)) { > - of_node_put(refnp); > + if (!of_property_read_u32(refnp, "clock-frequency", &fref)) > break; > - } > } > > ccm = of_iomap(np, 0); >
