Micha Nelissen wrote: > > Alexandre Bounine wrote: > > + > > + if (err_status & RIO_PORT_N_ERR_STS_PW_OUT_ES) { > > + pr_debug("RIO_EM: servicing Output Error-Stopped state\n"); > > + /* > > + * Send a Link-Request/Input-Status control symbol > > + */ > > + > > + /* Read from link maintenance response register > > + * to clear valid bit */ > > + rio_mport_read_config_32(mport, destid, hopcount, > > + rdev->phys_efptr + RIO_PORT_N_MNT_RSP_CSR(pnum), > > + ®val); > > + udelay(50); > > Perhaps this whole part of operating the MNT_RSP registers (sending > link-request symbol is the only useful action IIRC?) can be put in a > separate function for readability. > I was on the fence with this one. Now I have an extra vote in favor of a separate function ;) Will do. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
- [PATCH 3/9] RapidIO: Add the ingress port number into t... Alexandre Bounine
- Re: [PATCH 3/9] RapidIO: Add the ingress port numb... Micha Nelissen
- RE: [PATCH 3/9] RapidIO: Add the ingress port ... Bounine, Alexandre
- [PATCH 4/9] RapidIO: Add relation links between RIO dev... Alexandre Bounine
- Re: [PATCH 4/9] RapidIO: Add relation links betwee... Micha Nelissen
- RE: [PATCH 4/9] RapidIO: Add relation links be... Bounine, Alexandre
- Re: [PATCH 4/9] RapidIO: Add relation link... Micha Nelissen
- RE: [PATCH 4/9] RapidIO: Add relation ... Bounine, Alexandre
- [PATCH 5/9] RapidIO: Add default handler for error_stop... Alexandre Bounine
- Re: [PATCH 5/9] RapidIO: Add default handler for e... Micha Nelissen
- RE: [PATCH 5/9] RapidIO: Add default handler f... Bounine, Alexandre
- [PATCH 6/9] RapidIO: Add switch-specific sysfs initiali... Alexandre Bounine
- Re: [PATCH 6/9] RapidIO: Add switch-specific sysfs... Micha Nelissen
- RE: [PATCH 6/9] RapidIO: Add switch-specific s... Bounine, Alexandre
- Re: [PATCH 6/9] RapidIO: Add switch-specif... Micha Nelissen
- RE: [PATCH 6/9] RapidIO: Add switch-sp... Bounine, Alexandre
- [PATCH 7/9] RapidIO: Add handling for PW message from a... Alexandre Bounine
- Re: [PATCH 7/9] RapidIO: Add handling for PW messa... Micha Nelissen
- RE: [PATCH 7/9] RapidIO: Add handling for PW m... Bounine, Alexandre
- Re: [PATCH 7/9] RapidIO: Add handling for ... Micha Nelissen
- RE: [PATCH 7/9] RapidIO: Add handling ... Bounine, Alexandre