> -----Original Message-----
> From: Scott Wood [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, August 14, 2007 11:16 AM
> To: Andy Fleming
> Cc: [EMAIL PROTECTED]; [email protected]
> Subject: Re: [PATCH] [UPDATED] tsec: Allow Ten Bit Interface to be
> configurable
> 
> Andy Fleming wrote:
> > It's actually a per-tsec property.  There's not one tbi, there's one
> > per TSEC.  The one on TSEC 0 is special in that it can interfere with
> > PHYs on the MDIO bus.
> >
> > So I would suggest making it a property of the ethernet node:
> >
> > [EMAIL PROTECTED] {
> > ...
> > tbipa = <1f>;
> > ...
> > }
> 
> "tbipa" isn't likely to pass the Segher test. :-)
> 
> If the TBI address is in PHY-space, then it should go in the MDIO bus.
> For the second TSEC, create a second MDIO bus node.
> 

How about something like this?

                [EMAIL PROTECTED] {
                        #address-cells = <1>;
                        #size-cells = <0>;
                        device_type = "mdio";
                        compatible = "gianfar";
                        reg = <24520 20>;
                        phy1f: [EMAIL PROTECTED] {
                                reg = <1f>;
                                device_type = "ethernet-phy";
                        };
                        phy0: [EMAIL PROTECTED] {
                                reg = <0>;
                                device_type = "ethernet-phy";
                        };
                        phy1: [EMAIL PROTECTED] {
                                reg = <1>;
                                device_type = "ethernet-phy";
                        };
                        phy2: [EMAIL PROTECTED] {
                                reg = <2>;
                                device_type = "ethernet-phy";
                        };
                        tbi1e: [EMAIL PROTECTED] {
                                reg = <1e>;
                                device_type = "ethernet-tbi";
                        };
                };

                [EMAIL PROTECTED] {
                        #address-cells = <1>;
                        #size-cells = <0>;
                        device_type = "network";
                        model = "eTSEC";
                        compatible = "gianfar";
                        reg = <24000 1000>;
                        mac-address = [ 00 E0 0C 00 73 00 ];
                        interrupts = <1d 2 1e 2 22 2>;
                        interrupt-parent = <&mpic>;
                        phy-handle = <&phy1f>;
                        tbi-handle = <&tbi1e>;
                };


Joe


_______________________________________________
Linuxppc-embedded mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-embedded

Reply via email to