Saturday, April 7, 2018 10:35 PM

I think everything looks good. The only thing that I noticed is coding style 
things.

Patch 1/12
> -     node->pmc = pmc_create(cfg, TRANS_UDS, uds_local, 0, domain_number, 0, 
> 1);
> +     node->pmc = pmc_create(cfg, TRANS_UDS, uds_local, 0,
> +                      config_get_int(cfg, NULL, "domainNumber"), 0, 1);

Indentation not correct

8/12
> -                     if (get_arg_val_i(c, optarg, &node.sanity_freq_limit, 
> 0, INT_MAX))
> +                     if (get_arg_val_i(c, optarg, &node.sanity_freq_limit, 
> 0, INT_MAX) ||
> +                         config_set_int(cfg, "sanity_freq_limit", 
> node.sanity_freq_limit))
>                               goto end;

Maybe fix the missing braces here. Easy to see the changes anyway

10/12
> +             case 0:
> +                     if (config_parse_option(cfg, opts[index].name, optarg))
> +                             goto bad_usage;
> +                     break;
Missing braces

12/12
>       node->pmc = pmc_create(cfg, TRANS_UDS, uds_local, 0,
> -                      config_get_int(cfg, NULL, "domainNumber"), 0, 1);
> +                      config_get_int(cfg, NULL, "domainNumber"),
> +                      config_get_int(cfg, NULL, "transportSpecific") << 4, 
> 1);

Same as 1/12

/Anders

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to