On Sat, Apr 07, 2018 at 10:35:10PM +0200, Peter Schneider wrote:
> Use struct config item 'clock_servo' for
> parameter handling. Copy this to node.servo_type afterwards.

Please format your paragraphs evenly, for example:

   Use struct config item 'clock_servo' for parameter handling. Copy this
   to node.servo_type afterwards.

> @@ -1541,6 +1544,7 @@ int main(int argc, char *argv[])
>       print_set_verbose(config_get_int(cfg, NULL, "verbose"));
>       print_set_syslog(config_get_int(cfg, NULL, "use_syslog"));
>       print_set_level(config_get_int(cfg, NULL, "logging_level"));
> +     node.servo_type = config_get_int(cfg, NULL, "clock_servo");


This is good, but you also should then remove the now useless
initialization...

        struct node node = {
                .sanity_freq_limit = 200000000,
                .servo_type = CLOCK_SERVO_PI,
here ----------/
                .phc_readings = 5,
                .phc_interval = 1.0,
                .kernel_leap = 1,
        };

Thanks,
Richard

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to