On Sat, Oct 12, 2019 at 08:49:54PM -0700, Richard Cochran wrote:
> On Thu, Sep 26, 2019 at 03:54:32PM +0200, Miroslav Lichvar wrote:
> > +   free(table->peer_name);
> 
> This needs test for table->peer_name != NULL ...

> > +   if (table->peer_name)
> > +           cloned_table->peer_name = strdup(table->peer_name);
> 
> ... doesn't it?

I think free(NULL) is required to be a no-op, so that test would be
unnecessary, but if there is another reason like coding style, I can
add it to the patch.

Thanks,

-- 
Miroslav Lichvar



_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to