On Mon, Oct 21, 2019 at 07:09:35AM -0700, Richard Cochran wrote:
> On Thu, Sep 26, 2019 at 03:54:32PM +0200, Miroslav Lichvar wrote:
> > Don't require each port to have its own master table specified in the
> > config. Instead of ports claming configured tables, clone the table in
> > each port, so different ports don't interfere with each other.
>
> I'd like to tack on this delta with error path cleanups.
Thanks for catching the leaks.
> Can you please check it for me?
Looks good to me except ...
> if (unicast_client_enabled(p) &&
> config_set_section_int(cfg, p->name, "hybrid_e2e", 1)) {
> - goto err_transport;
> + goto err_uc_client;
> }
> if (number && unicast_service_initialize(p)) {
> - goto err_transport;
> + goto err_uc_client;
> }
> err_tsproc:
> tsproc_destroy(p->tsproc);
> +err_uc_client:
> + unicast_client_cleanup(p);
> +err_uc_service:
> + unicast_service_cleanup(p);
> err_transport:
> transport_destroy(p->trp);
err_uc_service should be before err_uc_client as the service is
initialized after the client.
--
Miroslav Lichvar
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
