On Wed, Aug 05, 2020 at 04:37:26PM -0700, Jacob Keller wrote:
> 
> It feels a bit weird that this code isn't already itself a separate .c
> file that can be reused or shared with other programs that create
> clocks. But you're mostly just moving this code here from a previous
> location so I think it is fine.
> 

Those other callers don't have the same definition of a 'struct clock',
and therefore, even if the logic is the same, the generated assembly
code isn't. You'll see this theme recurring in the
ts2phc_recv_subscribed() function which is the same logic as
phc2sys_recv_subscribed() except for a different priv structure.
That one also has a FIXME next to it, so if you have any idea it would
be appreciated.

Thanks,
-Vladimir


_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to