Vladimir,
On Tue, Aug 04, 2020 at 02:40:11PM +0300, Vladimir Oltean wrote:
> The diff is large, yes, even though I tried to avoid making unnecessary
> changes. I hope it isn't too difficult to review, it isn't as polished
> as I typically like, because the idea itself was uncertain, so I
> preferred not to spend that extra time at this point in the process.
> Anyways, I'm looking forward to your feedback whenever you have the
> time.
I was going to begin my review, but first I ran my ts2phc smoke test.
Valgrind found a memory leak.
Thanks,
Richard
sudo valgrind ./ts2phc -f ts2phc-TC.cfg --free_running=1
...
Control-C...
==9363== HEAP SUMMARY:
==9363== in use at exit: 1,022 bytes in 10 blocks
==9363== total heap usage: 279 allocs, 269 frees, 20,230 bytes allocated
==9363==
==9363== LEAK SUMMARY:
==9363== definitely lost: 568 bytes in 4 blocks
==9363== indirectly lost: 454 bytes in 6 blocks
==9363== possibly lost: 0 bytes in 0 blocks
==9363== still reachable: 0 bytes in 0 blocks
==9363== suppressed: 0 bytes in 0 blocks
==9363== Rerun with --leak-check=full to see details of leaked memory
--- ts2phc-TC.cfg ---
# for use with three i210 cards
[global]
use_syslog 0
verbose 1
logging_level 6
ts2phc.pulsewidth 500000000
[eth3]
ts2phc.channel 0
ts2phc.master 1
ts2phc.pin_index 0
[eth4]
ts2phc.channel 0
ts2phc.extts_polarity both
ts2phc.pin_index 0
[eth6]
ts2phc.channel 0
ts2phc.extts_polarity both
ts2phc.pin_index 0
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
