On Fri, Jun 03, 2022 at 11:52:41AM +0530, SyncMonk Technologies wrote:
> As per IEEE1588-2019, Table 21 adding NO_MECHANISM support. In this
> case port does not implement the delay mechanism.
Looks good to me with few minor issues. See below.
> --- a/config.c
> +++ b/config.c
> @@ -168,9 +168,10 @@ static struct config_enum delay_filter_enu[] = {
> };
>
> static struct config_enum delay_mech_enu[] = {
> - { "Auto", DM_AUTO },
> - { "E2E", DM_E2E },
> - { "P2P", DM_P2P },
> + { "Auto", DM_AUTO },
> + { "E2E", DM_E2E },
> + { "P2P", DM_P2P },
> + { "NO_MECHANISM", DM_NONE },
Should this be the other way around? When you said you wanted the
naming to follow the spec and I suggested that at least the user
visible string should be "none", I meant the configuration, not the
code. Let's see what Richard thinks.
> @@ -205,10 +206,10 @@ static struct config_enum timestamping_enu[] = {
> };
>
> static struct config_enum tsproc_enu[] = {
> - { "filter", TSPROC_FILTER },
> - { "raw", TSPROC_RAW },
> - { "filter_weight", TSPROC_FILTER_WEIGHT },
> - { "raw_weight", TSPROC_RAW_WEIGHT },
> + { "filter", TSPROC_FILTER },
> + { "raw", TSPROC_RAW },
> + { "filter_weight", TSPROC_FILTER_WEIGHT },
> + { "raw_weight", TSPROC_RAW_WEIGHT },
> { NULL, 0 },
This hunk should be removed.
> --- a/ptp4l.8
> +++ b/ptp4l.8
> @@ -338,10 +343,10 @@ smaller than this value the port is marked as not
> 802.1AS capable.
> .TP
> .B tsproc_mode
> Select the time stamp processing mode used to calculate offset and delay.
> -Possible values are filter, raw, filter_weight, raw_weight. Raw modes perform
> -well when the rate of sync messages (logSyncInterval) is similar to the rate
> of
> -delay messages (logMinDelayReqInterval or logMinPdelayReqInterval). Weighting
> -is useful with larger network jitters (e.g. software time stamping).
> +Possible values are filter, raw, filter_weight, raw_weight, no_delay. Raw
> modes
> +perform well when the rate of sync messages (logSyncInterval) is similar to
> the
> +rate of delay messages (logMinDelayReqInterval or logMinPdelayReqInterval).
> +Weighting is useful with larger network jitters (e.g. software time
> stamping).
> The default is filter.
And this one as well.
--
Miroslav Lichvar
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
