On Wed, Feb 24, 2010 at 08:49:44AM -0600, Chris Bagwell wrote: > On Tue, Feb 23, 2010 at 11:27 PM, Peter Hutterer > <peter.hutte...@who-t.net> wrote: > > On Tue, Feb 23, 2010 at 08:55:38PM -0600, ch...@cnpbagwell.com wrote: > >> From: Chris Bagwell <ch...@cnpbagwell.com> > > Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> > > > > again, I'd like to know Ping's input on this, I don't quite know what the > > MaxX and stuff was for. And why we have a different MaxX and maxTouchX > > anyway? > > I can answer the second question because originally I tried getting > rid of maxTouch*. The reason is because of ISDV4 devices. They read > directly from 1 serial device so all the types's are multiplexed to > single DEVICE. They want to store in the common structure a min/max > of X/Y for both the pen part of tablet and another for touch part of > tablet. So they need two sets of variables. Later, they are copied > to priv structures. > > The only reason to store in common struct is related to GetRanges() > only be called once at device open. Perhaps we should support calling > GetRanges() for all device types instead of just on open. Then most > Max* values would become priv-only values.
I'm not quite sure I understand what you wrote here. ISDV4 devices - do they end up as multiple devices in X just like the usb devices? If so, can't we use the same technique to gather the right data from the device (depending on the "type" option)? Or am I missing something here? fwiw, I'm currently looking at the initialization sequence for wacom and one of the things I'm trying to fix is the multiple open calls and the rather awkward order of everything. Ideally, we'd have a single open call, followed by the device probing, followed by everything else. I think auto-dev is currently broken as well, given the order of tests in wcmInit. > I, also, don't quite understand Max* logic right now. I would like > help understanding it because a related question came up twice in > conversations yesterday. > > If your tablet ratio isn't same as your screen ratio then drawing an > exact circle on tablet doesn't draw an exact circle on screen. What > is the solution for this? Is it adjusting Bottom* values to make > tablet ratio match screen or is it adjusting Max* values? I think that's what the option "KeepShape" is for. not sure if it works, haven't tried it yet. Cheers, Peter ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
