Ping, do you think the cleanup patch is acceptable then? To summarize the patch: it was removing broken logic that looked at xorg.conf values for maxX/Y/Z because user values were always thrown away.
Based on responses so far and further reviews I've been doing, I think we can safely say there is no current need for user to be able to set/override those Max values reported by hardware... so no need to get the broken logic working. Chris On Sat, Feb 27, 2010 at 7:41 PM, Ping Cheng <pingli...@gmail.com> wrote: > Chris is right. Serial device (ISDV4) only has one port and we need > to keep both touch and pen info separately in the common structure. We > could call GetRanges more than once so touch and pen info are stored > in priv locally. That would slow down the initialization process. I > don't think we want to do that. > > As for why we need the user defined MaxX/Y options, I have no idea. > They were introduced by Fred. I guess we could use them to set up a > pseudo tablet for some weird mapping purpose - doubling the width of > the tablet in a dual display environment so the whole tablet would be > mapped to a particular screen? There are all kinds of creative > features with open source project :). > > Ping > > On Wed, Feb 24, 2010 at 6:49 AM, Chris Bagwell <ch...@cnpbagwell.com> wrote: >> On Tue, Feb 23, 2010 at 11:27 PM, Peter Hutterer >> <peter.hutte...@who-t.net> wrote: >>> On Tue, Feb 23, 2010 at 08:55:38PM -0600, ch...@cnpbagwell.com wrote: >>>> From: Chris Bagwell <ch...@cnpbagwell.com> >>> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> >>> >>> again, I'd like to know Ping's input on this, I don't quite know what the >>> MaxX and stuff was for. And why we have a different MaxX and maxTouchX >>> anyway? >> >> I can answer the second question because originally I tried getting >> rid of maxTouch*. The reason is because of ISDV4 devices. They read >> directly from 1 serial device so all the types's are multiplexed to >> single DEVICE. They want to store in the common structure a min/max >> of X/Y for both the pen part of tablet and another for touch part of >> tablet. So they need two sets of variables. Later, they are copied >> to priv structures. >> >> The only reason to store in common struct is related to GetRanges() >> only be called once at device open. Perhaps we should support calling >> GetRanges() for all device types instead of just on open. Then most >> Max* values would become priv-only values. >> >> I, also, don't quite understand Max* logic right now. I would like >> help understanding it because a related question came up twice in >> conversations yesterday. >> >> If your tablet ratio isn't same as your screen ratio then drawing an >> exact circle on tablet doesn't draw an exact circle on screen. What >> is the solution for this? Is it adjusting Bottom* values to make >> tablet ratio match screen or is it adjusting Max* values? >> >> My screen is close enough to my tablet (I guess) that I don't see the >> issue... but others have reported it. >> >> Chris >> >> ------------------------------------------------------------------------------ >> Download Intel® Parallel Studio Eval >> Try the new software tools for yourself. Speed compiling, find bugs >> proactively, and fine-tune applications for parallel performance. >> See why Intel Parallel Studio got high marks during beta. >> http://p.sf.net/sfu/intel-sw-dev >> _______________________________________________ >> Linuxwacom-devel mailing list >> Linuxwacom-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel >> > ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
