On Fri, Jan 07, 2011 at 11:10:30AM +1000, Peter Hutterer wrote: > On Thu, Jan 06, 2011 at 04:46:46PM -0800, Ping Cheng wrote: > > On Thu, Jan 6, 2011 at 2:56 PM, Peter Hutterer <[email protected]> > > wrote: > > >> Another idea comes up when I read this patch. For both ring and > > >> strips, the time that we want to post an event is when the finger > > >> moved on the ring or strip in a direction. If it stays at or touches > > >> one point then leaves, the value below can be non-zero. But we can not > > >> post an event since there is no movement on the surface involved. This > > >> case could happen if ds->abswheel = 0 (leaving) or priv->oldWheel = 0 > > >> (touching). A check to !ds->abswheel && !priv->oldWheel need to be > > >> added to the above if-statement. priv->oldStripX/Y and ds->stripx/y > > >> need to be considered for patch 5/5. > > > > > > that's what I had originally (one reason I introduced the MAX_PAD_RING > > > define) but then I figured if we have proximity, we should use it as > > > intended :) > > > > But if we don't get out-prox event, oldProximity would always be the > > same as proximity, right? A check on zero safeguards that case. > > > > It's a corner case. But I do see events emitted when touch and leave > > on one point sometime. > > Ah, now I understand the problem. you mean you get scroll events when you're > essentially tapping the strip? i'll see if I get this my I4/I3, should be > easy enough to fix.
fwiw, I don't get any events in this case, only in the odd case where my finger must move just slighly enough to trigger a movement. pure tapping doesn't seem to generate any scroll events and being careful not to move the finger before lifting it doesn't either. Cheers, Peter ------------------------------------------------------------------------------ Gaining the trust of online customers is vital for the success of any company that requires sensitive data to be transmitted over the Web. Learn how to best implement a security strategy that keeps consumers' information secure and instills the confidence they need to proceed with transactions. http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
