On Mon, Oct 8, 2012 at 9:24 AM, Bastien Nocera <had...@hadess.net> wrote: > On Mon, 2012-10-08 at 18:12 +0200, Olivier Fourdan wrote: >> Hi Bastien, >> >> Bastien Nocera said the following on 10/08/2012 06:06 PM: >> > On Mon, 2012-10-08 at 17:39 +0200, Olivier Fourdan wrote: >> >> As discussed on linuxwacom-devel mailing list, add a new "Integrated" >> >> feature >> >> for integrated system devices to identify eg. Tablet PC. >> >> >> >> Olivier Fourdan (2): >> >> lib: add "Integrated" feature >> >> data: add the Integrated field to ISD definitions >> > Can't we find a better name than this? It means nothing unless you've >> > been working on Wacom tablets for a long while... >> >> "TabletPC" was suggested, or "ISD" (but I find the later even more >> cryptic). >> >> I did not choose "TabletPC" because I wasn't sure if all integrated >> device would be TabletPC. >> >> But if TabletPC is preferable, I have no problem changing the names to >> that. > > Looks to me like "builtin" is "tablet is integrated with the display" > and "ISD" is "tablet is integrated with the computer".
I agree with Bastien. "builtin" == "tablet is integrated with the display" == INPUT_PROP_DIRECT (defined in the kernel) > I'm sure we could deprecate the _is_builtin() function, and use a > bitmask for this support instead? > > LIBWACOM_DEVICE_INTEGRATED_WITH_NONE = 0, > LIBWACOM_DEVICE_INTEGRATED_WITH_DISPLAY = 1 << 0, > LIBWACOM_DEVICE_INTEGRATED_WITH_COMPUTER = 1 << 2 I don't care which term/function name we use as long as they are consistent with what defined in the kernel/driver. Plus, they are documented. ;-). Ping ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
