On Tue, Oct 16, 2012 at 04:40:14PM +0200, Olivier Fourdan wrote: > > Hi Peter, > > Peter Hutterer said the following on 10/16/2012 07:35 AM: > > From 0216649221b0b4776d322ae25e1b7dba8d07dd84 Mon Sep 17 00:00:00 2001 > >From: Olivier Fourdan<ofour...@redhat.com> > >Date: Wed, 3 Oct 2012 15:31:24 +0200 > >Subject: [PATCH 2/2] lib: add helper functions to list available status LED > > > >Parses the newly added "StatusLEDs" field from the > >database entries, > > > >Adds a WacomStatusLEDs enumeration type to identify > >known status LED types, > > > >Adds libwacom_get_status_leds() function to retrieve the > >number and list of status LED availble on the device in > >the same order as their controlling entry in SysFS, > > > >Adds libwacom_get_button_led_group() function to get the > >LED group correspondoing to a given mode switch button, > >or -1 if no LED is avaiable for that mode switch. > > > >Signed-off-by: Olivier Fourdan<ofour...@redhat.com> > >--- > >git bisect claims this broke make check (dbverify segfaults). Can you please > >double-check that? thanks. > > Well, actually, this is not a segfault but an assert() which fails. > > Reason it fails is because it compares the definition in the old database > against the new one, problem these patches add new information that were not > present in the older database so these tests will necessarily fail each time > we add new information to the existing entries of the database.
dbverify doesn't really have a old/new database though. it loads the database once, writes it to a file, then re-reads that file as new database and compares it to the original. Theory goes that the two databases have to be identical, otherwise either write or read is broken. In my case it breaks on the first I4 tablet, so I suspect the LED stuff either doesn't print correctly, compare correctly or read correctly*. This is the real problem we need to find. Cheers, Peter * or the test case is broken, but it's simple enough that it shouldn't be. ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
