On 17/10/12 18:00 , Olivier Fourdan wrote: > Hey Peter, > > Peter Hutterer said the following on 10/17/2012 09:48 AM: >>> I shall send a fix to get to the same level as that one then. >> >> if that's the only difference, just revert the current patch and apply >> the right one on top, no need to diff the two up. > > But it's been already pushed and a revert would look ugly, wouldn't it?
we're not in for a beauty contest :) revert vs diff is always a personal decision, I admit. IMO ideally each bug fix is a single patch only* (for the purpose of git blame or backporting). So when you notice that the wrong patch got pushed, or that there was a bit missing, a revert can sometimes be better than a new patch - it explicitly shows what went wrong, why, and then has the fix for it in one unit. That can be very useful. Never be afraid of reverting. A nice looking history isn't necessarily the same thing as a useful history. Cheers, Peter * yeah, I know, we don't write perfect code... one can dream. > Anyway, I sent the 1-liner patch in the meantime. ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
