valentinagiusti added inline comments. ================ Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:805 @@ -827,2 +804,3 @@ + if (m_xstate_type == XStateType::Invalid) { if (const_cast<NativeRegisterContextLinux_x86_64 *>(this)->ReadFPR().Fail()) return false; ---------------- labath wrote: > Then I think we should make that non-const as well. I mean, what's the point > of making it const if it does actually modify the state of the object. Either > that, or implement it in a way that does not modify the state. This involves changing the interface of NativeRegisterContextLinux just because NativeRegisterContextLinux_x86_64 has some specific needs that make GetRegisterCount use a non-const function. Also, I don't have all the hardware to test such a cross-platform change.
https://reviews.llvm.org/D24764 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits