labath added a comment.

So, the thing is that you already are changing the interface. The difference is 
that you are using the const cast to hide that fact, which is why I dont 
approve of it.

Also, since this is not an existing problem but rather something you are 
introducing in this change, I dont thinl it's appropriate to do it as a 
follow-up,  but rather as a prep work for this  change.

One possibility I would consider is to do any work you need to do before this 
function even executes (e.g. in the constructor - the result of 
IsCpuFeatureAvailable cannot change during the lifetime of the process anyway, 
right?). I am OOO today so I cannot really tell how feasible that ideaIis. I 
can look at It tomorrow.

lldb-commits mailing list

Reply via email to