Nerixyz wrote: > Rather than keeping the path information in two places and checking that they > match in debug builds, we should make these TableGen definitions the one > source of truth.
If I understand you correctly: Every component that registers settings would go directly to the `Debugger` with the path from the TableGen definitions. For example, the setting for `plugin.dynamic-loader.darwin-kernel` is currently registered like this: https://github.com/llvm/llvm-project/blob/275eea298b0fc33b02044f552195f6e297aa7801/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp#L1630-L1637 If we were to use the TableGen definitions it would be something like ```cpp if (!debugger.GetSetting(GetGlobalProperties().GetPath())) debugger.CreateSetting(GetGlobalProperties().GetPath(), GetGlobalProperties().GetValueProperties(), is_global); ``` This would certainly be a bigger refactoring. https://github.com/llvm/llvm-project/pull/179524 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
