https://github.com/JDevlieghere approved this pull request.

> Opened #180232 for this. The second commit there 
> ([Nerixyz@141c1b1](https://github.com/Nerixyz/llvm-project/commit/141c1b1de4070c2cbcba352c3de6b0dd357aa2f8))
>  implements the suggestion in that it uses `SetPropertiesAtPathIfNotExists` 
> to add properties. Could you take a peek at this?

The approach in this commit looks fine to me and seems well suited to be a 
separate PR. We can keep the runtime verification until we do both plugin and 
non-plugins. I think it would be nice to have a generic `GetPropretiesForPath` 
that ideally can handle both. 

https://github.com/llvm/llvm-project/pull/179524
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to